ParabolInc / parabol

Free online agile retrospective meeting tool
https://www.parabol.co/
Other
1.91k stars 331 forks source link

GQLExecutor memory leak #9262

Open Dschoordsch opened 10 months ago

Dschoordsch commented 10 months ago

The GQLExecutor memory consumption goes steadily up. As seen on here 🔒(top three lines)

Screenshot 2023-12-04 at 12 13 14

the memory usage stayed high even through the weekend where I would expect it to drop.

Dschoordsch commented 10 months ago

Labelling it P3 as it's not critical now. Could be related to #8414

Dschoordsch commented 10 months ago

@rafaelromcar-parabol This could be an issue if we don't release for some time, like over christmas

rafaelromcar-parabol commented 10 months ago

We should keep an eye on it, for sure. But keep in mind that if the containers arrive to 4 GB of memory, they will be automatically restarted.

That said, we could restart the application next week before Christmas if needed. During the week or on the weekend. It can be done easily using the last pipeline in the Gitlab repository.

rafaelromcar-parabol commented 10 months ago

Also, I think this should be a P2. Mem leaks should always be fixed asap as they can affect stability. Even more in our application, that doesn't like restarting components very much. At least it didn't before this. Let's see after the release this week.

mattkrick commented 10 months ago

Blocked behind #9282

rafaelromcar-parabol commented 10 months ago

I was checking the memory usage on the GQL Ex and they are fine but at more than 60%. Which is fine, because if we do not release, the worst that can happen is having Kubernetes restarting them if they reach 100%. It isn't a big problem. Just sharing my thoughts here.

mattkrick commented 10 months ago

true for the saas! for certain clients who do do not manage their infra as diligently as we do, restarts may pose a problem 😅

rafaelromcar-parabol commented 10 months ago

Of course! I was talking about the Christmas period for the SaaS 😸 PPMIs haven't been updated in a long while. They are still in 6.83.0 and they have been like that for a while.

jordanh commented 7 months ago

Prioritized to backlog

github-actions[bot] commented 1 month ago

Stale issue