ParabolInc / parabol

Free online agile retrospective meeting tool
https://www.parabol.co/
Other
1.91k stars 326 forks source link

chore: Show only available integrations #9908

Closed Dschoordsch closed 3 months ago

Dschoordsch commented 3 months ago

Description

Fixes #9879 Hide Github, Atlassian and Slack integrations if the oauth environment variables are not set.

If a user has integrated with any of these in the past, then this is not changed. They will be able to use the integration until their token expires. This was already the case before. This PR only affects the visibility of the provider rows.

Demo

https://www.loom.com/share/881a214cb5c042aba2f9df3a96f6f190?sid=658c14b3-8343-4d08-ac48-6cec0b67ed6d 🔒

Testing scenarios

Final checklist

rafaelromcar-parabol commented 3 months ago

LGTM!

Just one question: what happens if no integration is available? Shouldn't we show something? I think on the video you say some integrations will always be shown there but I think we should allow to disable those too.

rafaelromcar-parabol commented 3 months ago

Also, IMHO this PR would require a full testing round before being released to production.

Dschoordsch commented 3 months ago

what happens if no integration is available? Shouldn't we show something?

I think we should ignore this case. This is only an edge case for private instances. These get support from us in any case, so it's not an issue.

some integrations will always be shown there but I think we should allow to disable those too.

I can add 2 variables to disable Mattermost and MS Teams.

Also, IMHO this PR would require a full testing round before being released to production.

No objection against testing, but it just touches some UI elements, no logic changed. Production should look exactly the same.

rafaelromcar-parabol commented 3 months ago

I think we should ignore this case.

Agreed. I was just curious.

I can add 2 variables to disable Mattermost and MS Teams.

If it's easy and quick, I think you should, but I'll approve the PR without that, as it's not a requirement.

No objection against testing, but it just touches some UI elements, no logic changed. Production should look exactly the same.

I thought it might risk something other than the UI. In that case, go ahead @Dschoordsch !