Responsive - Githubissues

Paraclete23 / f1-3-c2p1-colmar-academy

0 stars 0 forks source link

Open tommygebru opened 5 years ago

tommygebru commented 5 years ago

Really nice work on using multiple images for separate layouts Dakota, also really great use of fluid typography and responsive web design made possible with REM Implementing REM in CSS (or, How to Be a Shiny Happy Developer) - Words and Code

Your transition between different layouts is smooth, great use of the entire pages length and width.

tommygebru commented 5 years ago

Minor typos and errors:

In your Campus section, you are missing a .container div to wrap around your .LeftSide and .RightSide parent elements. So the following styles are missing from this page section:
```
max-width: 1050px;
margin: 0 auto;
```
In you mobile layout, the Courses section is puching elements outside of the body, consider changing the width of your anchor elements For example:
```
.CourseList a{
width: 90%;
}
```