Paraclete23 / prj-rev-bwfs-dasmoto

0 stars 0 forks source link

Rubric and Summary #4

Open ulisigi opened 5 years ago

ulisigi commented 5 years ago

Rubric Score

Criteria 1: HTML and CSS Linking

Criteria 2: Implementation of Design Specification and Content

Criteria 3: HTML Elements and Content

Tags: The tags in the HTML are not used for their intended purpose (

for paragraphs, for headers, etc.) in 2-3 sections.

Criteria 4: CSS Selectors and Syntax

Overall Score: 14/16

Your project Exceeds Expectations - way to go! As the projects grow larger and more complex, I recommend including comments in both your HTML and CSS to help keep your code more readable and organized. Keep finding ways to include semantic elements in your HTML, as this will improve the accessibility of a site as well as further improve readability.

Here's an article about semantic HTML and accessibility: https://24ways.org/2017/accessibility-through-semantic-html/

Overall, great job on your first project submitted for review. Keep up the excellent work, and happy coding!

Paraclete23 commented 5 years ago

In regards to Criteria 3, I would like to know which tags would have been more acceptable. As far as inline editing with strong- I completely understand the use of would have been more appropriate. I appreciate the time and effort taken to review this project.

ulisigi commented 5 years ago

Criteria 3 was in regards to the <strong> and <span> tags that were highlighted in the the HTML Issue, as the <strong> tags were not used for their intended purpose in 3 sections of the project. The rest of your tags used in the project were appropriate, and it was good to see the use of <section> - this isn't often found in the Dasmoto project. Inline styling with a different tag is valid, but it would be a best practice to keep structure (HTML) and styling (CSS) separated by removing the inline styling and applying it from the CSS stylesheet. I hope this clarifies things for you. Happy coding!