ParadigmFoundation / zaidan-dealer-specification

Specification document's and scripts for the Zaidan Dealer JSONRPC specification.
Apache License 2.0
6 stars 3 forks source link

Consider removing optional parameters from `dealer_submitFill` #54

Closed hrharder closed 4 years ago

hrharder commented 4 years ago

It seems a little weird to say: “Implementations SHOULD strive to ONLY require the first three parameters for fill requests (quoteId, salt, and signature).”, but also provide optional parameters that “should be omitted” (data, hash). It may be better to be more opinionated here and exclude the parameters that “should be omitted” entirely.

h/t @steveklebanoff