search

ParadigmFoundation / zaidan-dealer-specification

Specification document's and scripts for the Zaidan Dealer JSONRPC specification.
Apache License 2.0
6 stars 3 forks source link

Remove "gasPrice" from TradeInfo schema #55

Closed L-Kov closed 4 years ago

L-Kov commented 4 years ago

While some information that is included in the current TradeInfo schema is relevant/helpful, the explicit definition of gasPrice is restricting for the dealer. On relatively large/valuable orders, or for low reputation takers, the dealer will likely want to have flexibility on the gas price value. As such, we should remove gasPrice from the TradeInfo schema.

hrharder commented 4 years ago

This is tricky -- because in 0x v3 the gas price is part of the data the taker must sign in their transaction, it is important that data is available.

If not here, at least in the quote that is provided.

hrharder commented 4 years ago

The main point is the taker needs to know the gas price at the time the quote is provided, because it must be included in the signature.

So either way, we will need to send the gas price to the taker with the quote, either in the TradeInfo object or as part of the top-level Quote itself.