ParadigmHyperloop / hyperloop

High Performance Hyperloop Pod Control Software
https://paradigmhyperloop.com
Other
17 stars 4 forks source link

Integration tests should use random ports #73

Open EdHurtig opened 7 years ago

EdHurtig commented 7 years ago

For the time being, the integration tests should use randomized ports for Logging and Commands. This will allow mutilple jobs to coexist without deadlocking each other.

In the future we will contain these jobs on the Jenkins server in individual docker containers, etc

EdHurtig commented 7 years ago

Related to #62

shorstman commented 7 years ago

Is there a range of valid ports/any ports that shouldn't be tested?

EdHurtig commented 7 years ago

uh anything in the unprivileged port range (I think anything above 1024 IIRC) is fine. Probably best to restrict the range to something like 20,000 to 30,000 and check the random port before starting the test.

All this logic of port selection can be done in ControllerTest.py

EdHurtig commented 7 years ago

Alternatively... could use this plugin https://wiki.jenkins.io/display/JENKINS/Port+Allocator+Plugin