search

ParadigmMC / mc-modpack-kit

A template designed to streamline the release process of Minecraft modpacks.
Creative Commons Zero v1.0 Universal
29 stars 10 forks source link

Client and server packs #57

Open Conquerix opened 11 months ago

Conquerix commented 11 months ago

Is it possible to have both client and server versions of one pack at the same time and released together for a new version ?

jh-devv commented 11 months ago

@Conquerix I haven't looked into it, but you could look into it if mc-publish supports it

Does this require different like upload locations? Like different pages etc. on Modrinth?

Conquerix commented 11 months ago

Actually I upload my pack to curse forge only (mainly because of the mod ms present). On there when uploading a client pack version, you can include other files, and people usually put the server versions there. I'll look a bit more into mc-publish

jh-devv commented 11 months ago

I'll look a bit more into mc-publish

Thanks! At least different upload locations on modrinth/curseforge is planned! :3

Conquerix commented 11 months ago

Ok so I looked into it a bit more, it seems that one can use files-primary and files-secondary to specify which files go where when uploading several of them In this discussion it seems to be the case, although I don't really know what globs are, I get the idea. With this it seems there need to be a way to distinguish easily between the server and client packs.

Maybe it would be worth looking at a setup with one repo for one modpack project, with one directory for the client and one for the server, instead of having one project per folder in the same repo.

Conquerix commented 11 months ago

Ok nevermind with the primary and secondary files they seem to be deprecated (see here) I wonder what would happen if the files input had several files in it. Would it need a lot of work to change ?

jh-devv commented 11 months ago

Would it need a lot of work to change ?

Hmm, idk if there is something like type: client type of stuff? But yea, currently its handling the uploads on its own (via GitHub Actions matrices) so it would be bit of an pain to change

Conquerix commented 11 months ago

The type: client thing seems to be in preparation for their v4 yup. I'll try and see in my project how to do it without the matrices, seems doable and I have some free time :D

Conquerix commented 11 months ago

Ok so I completely modified the pipeline on my repo to try without the matrices, basically it works. If you put several files in the files field of mc-publish, it will publish the first one as the main file and the others as secondary files. It is fully working in my project.

jh-devv commented 11 months ago

Ok so I completely modified the pipeline on my repo to try without the matrices, basically it works. If you put several files in the files field of mc-publish, it will publish the first one as the main file and the others as secondary files. It is fully working in my project.

The problem with this, does it work with other "monorepo" style of uploads? Like could It build like 3 different types of the pack e.g. quilt, fabric and forge like currently :3 ?

Conquerix commented 11 months ago

Ok so I completely modified the pipeline on my repo to try without the matrices, basically it works. If you put several files in the files field of mc-publish, it will publish the first one as the main file and the others as secondary files. It is fully working in my project.

The problem with this, does it work with other "monorepo" style of uploads? Like could It build like 3 different types of the pack e.g. quilt, fabric and forge like currently :3 ?

What we could do is having a hybrid solution, for example, have each subdirectory of the git repo represent one pack, and in those there could be either the packwiz repo or 2 subdirectories client and server, each containing the corresponding packwiz repo of the same pack. Btw,I've never seen a case where one pack has versions for different loaders without the versions being different projects, like Better MC

jh-devv commented 5 months ago

Ok so I completely modified the pipeline on my repo to try without the matrices, basically it works. If you put several files in the files field of mc-publish, it will publish the first one as the main file and the others as secondary files. It is fully working in my project.

The problem with this, does it work with other "monorepo" style of uploads? Like could It build like 3 different types of the pack e.g. quilt, fabric and forge like currently :3 ?

What we could do is having a hybrid solution, for example, have each subdirectory of the git repo represent one pack, and in those there could be either the packwiz repo or 2 subdirectories client and server, each containing the corresponding packwiz repo of the same pack. Btw,I've never seen a case where one pack has versions for different loaders without the versions being different projects, like Better MC

Currently, they are the same version because of #49