Broken upload to modrinth

[ghost]

When attempting to upload to modrinth, the workflow seems to be entirely broken.

https://github.com/DannyLeWasTaken/DAM/actions/runs/7769306879/job/21188244467

[ghost]

Second repo of the bug https://github.com/DannyLeWasTaken/DAM/actions/runs/7769371708/job/21188385469

[jh-devv]

Hey! I will look into this tomorrow! In the meantime, can you check that mc-modpack-kit is up to date? Bit tricky probably, cause it's just a template so no versioning yet! You could try to check the hash as an example. This will probably be addressed some time near future!

Can you also provided the logs of the whole workflow? I don't know why I can't access the ones you provided me (at least with detail) cause I have no permissions)?

Sincerely:

• jh-devv

[ghost]

Prepare all required actions
Getting action download info
Download action repository 'robinraju/release-downloader@v1.8' (SHA:efa4cd07bd0195e6cc65e9e30c251b49ce4d3e51)
Download action repository 'cardinalby/git-get-release-action@v1' (SHA:5172c3a026600b1d459b117738c605fabc9e4e44)
Download action repository 'Kir-Antipov/mc-publish@v3.3' (SHA:423b200ec84e6eefad726549c72513d7a9b4c2c0)
Run ./.github/actions/release
Run actions/checkout@v3
Syncing repository: DannyLeWasTaken/DAM
Getting Git version info
Temporarily overriding HOME='/home/runner/work/_temp/b374774f-e7bd-418f-a667-e722c487f858' before making global git config changes
Adding repository directory to the temporary git global config as a safe directory
/usr/bin/git config --global --add safe.directory /home/runner/work/DAM/DAM
/usr/bin/git config --local --get remote.origin.url
https://github.com/DannyLeWasTaken/DAM
Removing previously created refs, to avoid conflicts
/usr/bin/git submodule status
Cleaning the repository
Disabling automatic garbage collection
Setting up auth
Fetching the repository
Determining the checkout info
Checking out the ref
/usr/bin/git log -1 --format='%H'
'b0ea08bef1ef5ea2b4b6e945b9c39677b129a5d8'
Run robinraju/release-downloader@v1.8
Fetching release main-v1.1.0 from repo DannyLeWasTaken/DAM
Found release tag: main-v1.1.0
Downloading file: DAM-1.1.0.mrpack to: /home/runner/work/DAM/DAM
Done: /home/runner/work/DAM/DAM/DAM-1.1.0.mrpack
Run cardinalby/git-get-release-action@v1
Retrieving release by main-v1.1.0 tag...
Release found:
{
  url: 'https://api.github.com/repos/DannyLeWasTaken/DAM/releases/139785442',
  assets_url: 'https://api.github.com/repos/DannyLeWasTaken/DAM/releases/139785442/assets',
  upload_url: '[https://uploads.github.com/repos/DannyLeWasTaken/DAM/releases/139785442/assets{?name,label}](https://uploads.github.com/repos/DannyLeWasTaken/DAM/releases/139785442/assets%7B?name,label})',
  html_url: 'https://github.com/DannyLeWasTaken/DAM/releases/tag/main-v1.1.0',
  id: 139785442,
  author: {
    login: 'github-actions[bot]',
    id: 41898282,
    node_id: 'MDM6Qm90NDE4OTgyODI=',
    avatar_url: 'https://avatars.githubusercontent.com/in/15368?v=4',
    gravatar_id: '',
    url: 'https://api.github.com/users/github-actions%5Bbot%5D',
    html_url: 'https://github.com/apps/github-actions',
    followers_url: 'https://api.github.com/users/github-actions%5Bbot%5D/followers',
    following_url: '[https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}](https://api.github.com/users/github-actions%5Bbot%5D/following%7B/other_user%7D)',
    gists_url: '[https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}](https://api.github.com/users/github-actions%5Bbot%5D/gists%7B/gist_id%7D)',
    starred_url: '[https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}](https://api.github.com/users/github-actions%5Bbot%5D/starred%7B/owner%7D%7B/repo%7D)',
    subscriptions_url: 'https://api.github.com/users/github-actions%5Bbot%5D/subscriptions',
    organizations_url: 'https://api.github.com/users/github-actions%5Bbot%5D/orgs',
    repos_url: 'https://api.github.com/users/github-actions%5Bbot%5D/repos',
    events_url: '[https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}](https://api.github.com/users/github-actions%5Bbot%5D/events%7B/privacy%7D)',
    received_events_url: 'https://api.github.com/users/github-actions%5Bbot%5D/received_events',
    type: 'Bot',
    site_admin: false
  },
  node_id: 'RE_kwDOK6Sjhc4IVPTi',
  tag_name: 'main-v1.1.0',
  target_commitish: 'b0ea08bef1ef5ea2b4b6e945b9c39677b129a5d8',
  name: 'main: v1.1.0',
  draft: false,
  prerelease: false,
  created_at: '2024-02-03T20:44:43Z',
  published_at: '2024-02-03T20:45:06Z',
  assets: [
    {
      url: 'https://api.github.com/repos/DannyLeWasTaken/DAM/releases/assets/149635669',
      id: 149635669,
      node_id: 'RA_kwDOK6Sjhc4I60JV',
      name: 'DAM-1.1.0.mrpack',
      label: '',
      uploader: [Object],
      content_type: 'application/octet-stream',
      state: 'uploaded',
      size: 8601,
      download_count: 0,
      created_at: '2024-02-03T20:45:24Z',
      updated_at: '2024-02-03T20:45:24Z',
      browser_download_url: 'https://github.com/DannyLeWasTaken/DAM/releases/download/main-v1.1.0/DAM-1.1.0.mrpack'
    }
  ],
  tarball_url: 'https://api.github.com/repos/DannyLeWasTaken/DAM/tarball/main-v1.1.0',
  zipball_url: 'https://api.github.com/repos/DannyLeWasTaken/DAM/zipball/main-v1.1.0',
  body: '## [1.1.0](https://github.com/DannyLeWasTaken/DAM/compare/main-v1.0.2...main-v1.1.0) (2024-02-03)\n' +
    '\n' +
    '\n' +
    '### ☀ Modpack Changes\n' +
    '\n' +
    '* **modpack/autohud:** added autohud ([39463d0](https://github.com/DannyLeWasTaken/DAM/commit/39463d04020588ba9844130a78babf6b9f519e61))\n' +
    '* **modpack/betterthirdperson:** added better third person ([1e4aa4d](https://github.com/DannyLeWasTaken/DAM/commit/1e4aa4d8868a064c4ae8f09669761972d2067df0))\n' +
    '* **modpack/breezy:** added breezy ([2f555f7](https://github.com/DannyLeWasTaken/DAM/commit/2f555f74f00bbdccc0f7b779429909a6df5ef335))\n' +
    '* **modpack/macawslights:** added macaws lights and lamps ([46b6d08](https://github.com/DannyLeWasTaken/DAM/commit/46b6d08f1e1f4a83575720fce199cb26c1327da2))\n' +
    '* **modpack/mods:** added combat roll, alexs mobs, travelers backpack, create steam n rails, l_enders catacylcsm ([37da772](https://github.com/DannyLeWasTaken/DAM/commit/37da772a88d35ba694e2ff328899f2d0aba0718e))\n' +
    '* **modpack/notelemetry:** added no telemetry ([3b218ac](https://github.com/DannyLeWasTaken/DAM/commit/3b218ac3cd10e04dcb1fea2d5f98041e55e66591))\n' +
    '\n' +
    '\n' +
    '### ⛭ Miscellaneous\n' +
    '\n' +
    '* **main:** release 1.1.0 ([e53dd36](https://github.com/DannyLeWasTaken/DAM/commit/e53dd36470df5652bf7f0659fca18cbf7115d7df))'
}
Run if [ "false" = "true" ]; then
Setting release-type to release
Run echo "## [1.1.0](https://github.com/DannyLeWasTaken/DAM/compare/main-v1.0.2...main-v1.1.0) (2024-02-03)
Run echo "::notice ::⚙ Assets from latest release main-v1.1.0 downloaded successfully!"
Notice: ⚙ Assets from latest release main-v1.1.0 downloaded successfully!
Notice: ⚙ Latest release main-v1.1.0 description piped into a file successfully!
Run Kir-Antipov/mc-publish@v3.3
📤 Uploading assets to Modrinth
Error: ArgumentError: A version number is required to upload files to Modrinth. (Parameter 'request.version')

[ghost]

Seems to be a bug relating to Kir-Antipov/mc-publish@v3.3? But what is mc-modpack-kit? I did a merge from this template to my current codebase to ensure I was up to date in terms of github workflows

[jh-devv]

Seems to be a bug relating to Kir-Antipov/mc-publish@v3.3?

Yea, probably, it was a weird update cause it broke a lot of stuff, they also deprecated the older version instantly.

Though, this seemed to work before, weird...

But what is mc-modpack-kit?

It's just this project.

[Fauli1221]

I can confirm this issue https://github.com/Fauli1221/VKPony/actions/runs/7776974853/job/21204750195

[jh-devv]

@Fauli1221 @DannyLeWasTaken Fixed with commit https://github.com/jh-devv/mc-modpack-kit/commit/7133cdbcd76a83bfd0028ea7530e8db7b579f4ba Please report to this PR if it does not work!

[jh-devv]

@DannyLeWasTaken Working, right?

[Fauli1221]

Yeah the update fixed it for me sorry forgot to reply

[ghost]

Hey! Issue on my end seems to fixed as well. Sorry for the late reply!

[jh-devv]

No problem guys, take your time! 😅