ParadigmMC / mc-modpack-kit

A template designed to streamline the release process of Minecraft modpacks.
Creative Commons Zero v1.0 Universal
30 stars 14 forks source link

Possibly a bugged or incorrectly configured modpack forcing a publish each commit #74

Closed ghost closed 6 months ago

ghost commented 7 months ago

Describe the bug Each time a commit is made onto main, the commit itself will cause a publish to occur rather than updating a pull request.

Expected behavior It should make a pull request and not publish.

Logs https://pastebin.com/zWuHUX5i

jh-devv commented 7 months ago

This is intresting, could you share the GitHub repo by any change so I could see closer?

ghost commented 7 months ago

https://github.com/DannyLeWasTaken/DAM

jh-devv commented 7 months ago

https://github.com/DannyLeWasTaken/DAM

Could be caused by the "bit excessive" use of the bump action, release please should handle bumps by itself.

The action is mainly used for bumping from the 0.1.0 to 1.0.0, like beta to release.

You could try to generate an new project from the template if you want, since this seems like an release please thing, at least I haven't seen this before.

ghost commented 6 months ago

Gotcha. A fix would be nice since it would be annoying to have to do this if my modpack bugs out

Aninuscsalas commented 6 months ago

Same issue here:

Instead of bumping the pack and creating a PR the action releases itself as the previous version again and again.

jh-devv commented 6 months ago

https://stackoverflow.com/questions/75806309/release-please-creates-the-same-release-pr-after-merge Related?

jh-devv commented 6 months ago

Hey! I found the issue:

If you were previously configuring advanced options via GitHub action inputs, you will need to configure via the release-please manifest configuration instead. Below, you can see a mapping of the old option to the new option:

It seems that the update from release-please-action v3 to v4 broke this, weird that the dependency bot didn't find this as an issue!

jh-devv commented 6 months ago

This seems to be mainly the fault of GitHub actions, that's why the issue #78 was created...