ParadiseSS13 / Paradise

Paradise Station's GitHub main repository.
https://www.paradisestation.org/forum
GNU Affero General Public License v3.0
383 stars 1.15k forks source link

After SR revival you can still hear cult speak as non cultist #10268

Open farie82 opened 5 years ago

farie82 commented 5 years ago

Problem Description: You keep the ability to hear cult speak when revived using SR as a non cultist.

What did you expect to happen: Not to hear the nerds talk about their books

What happened instead: Slith could hear them discuss the harry potter books in full detail

Why is this bad/What are the consequences: This will give away a lot of knowledge to non cultists

Steps to reproduce the problem:

  1. Die
  2. Get revived by SR
  3. (optional maybe) stay in the revival area
  4. Let a cultist talk using cult speak
  5. Hear the cult speak as if you're a ghost. It has the F to follow in the text.

When did the problem start happening: Slith reported this yesterday. I myself have not heard it happen before.

Possibly related stuff (which gamemode was it? What were you doing at the time? Was anything else out of the ordinary happening?): Cult round ofcourse. It seems as if the cult speak didn't close after he was revived.

Ty-Omaha commented 5 years ago

No clue whats wrong but here's relevant (I think) files

https://github.com/ParadiseSS13/Paradise/blob/4bc1a1c1efbc5e5aa379e5c75e9edb55ecf0cc0a/code/game/gamemodes/cult/cult_comms.dm#L33-L37

https://github.com/ParadiseSS13/Paradise/blob/2ee4d10516475a144195f17be617f1ae5e0cf1ef/code/modules/reagents/chemistry/reagents/medicine.dm#L710

https://github.com/ParadiseSS13/Paradise/blob/73091bf78c29d6699348b17a5412cf3b2a2a3b17/code/modules/mob/living/stat_states.dm#L42

https://github.com/ParadiseSS13/Paradise/blob/6a6100c0dd75cf555f3fcc4a17ce4e3487b7c115/code/modules/mob/living/carbon/human/death.dm#L118

Deelite34 commented 5 years ago

As far as I remember with my cultist-cloning experiences, you can hear cultist "radio", can use cultist stuff, but can't speak in cult speak. In my case, It sounds more as if you are still a cultist, but some spaghetti code makes you lose ability to speak in cultish. In yours, if you were cultist before dying, I believe you are still but bit bugged cultist after reviving.

farie82 commented 5 years ago

Slith wasn't a cultist before dying. He just kept hearing the ghost chatter while he was alive.

Deelite34 commented 5 years ago

I just thought off something... didn't we get a feature merged in past, where you can would be able to hear ghost talk, if you are close enough to death? If so, it could be related. Ghosts can hear ghost chat, antag mind speech, and robots, and close-to-deaht person inherits it?

edit: Shift ended, so I'll post what just happend to me: I died, got revived. During surgery I was in crit. I noticed I was able to see borg radio, there even was follow button next to borg and ai names. I did not hear ghosts though.

KasparoVy commented 5 years ago

You can take the man out of the cult but you can't take the cult out of the man

Also FWIW I have died countless times and never once witnessed ghostspeak while in the process of dying.