ParadiseSS13 / Paradise

Paradise Station's GitHub main repository.
https://www.paradisestation.org/forum
GNU Affero General Public License v3.0
398 stars 1.19k forks source link

Fireproofness is inconsistent #10934

Closed Pennwick closed 2 months ago

Pennwick commented 5 years ago

Problem Description: Depending on if you're on fire or not you use two diffrent sets of checks for heating up. This isn't especially noticeable with hardsuits and firesuits but it can be an issue with fireproofing potions.

A body on fire only checks to see if the exosuit and head slot item are fireproof A body not on fire checks if each of your body parts is covered in fireproof material This can lead to a person in a hot room burning up if they're just wearing a fireproof leather jacket and sombrero, but if they light themselves on fire they'll start cooling down.

What did you expect to happen: It should be consistent. More likely with full body coverage being needed to protect, even when on fire. If you cover every inch of your body with fireproof material you should be safe in hot rooms and from being on fire.

What happened instead: Wrapped up in a jumpsuit, gloves, hat shoes, all fireproofed you're fine in a 1000C room, but light on fire and you start heating up. Strip everything but the hat and throw on a fireproofed jacket you'll burn up, unless you light yourself on fire.

Why is this bad/What are the consequences: Its highly inconsistent and makes slime fireproofing potions use kind of bizzare.

Steps to reproduce the problem: Create a hot room, I used the toxins burn chamber and just pumped superheated gas into the HE pipes. Have three sets of clothing: Control group: Firesuit and fire helmet, Full coverage: Fireproofed jumpsuit+gloves+shoes+hat, Skimpy: Fireproofed hat and exosuit(I used a bomber jacket which covers only the up upper and lower torso+arms) Face coverage doesn't matter so have a oxygen tank on your back and a mask of some sort to stop interference from hot lungs Wear the control suit into the 'sauna', you'll be fine Wear the full coverage suit into the hot room, you'll be fine Wear the skimpy set into the hot room, you'll burn due to uncovered legs feet and hands, not as fast as you would naked but pretty quick Splash some welding fuel on yourself and light yourself on fire With the control suit you'll be fine With the full coverage suit you'll quickly start burning up With the skimpy suit you'll be fine as the on_fire code only checks for hat and exosuit For one last oddity teleport into the hot room with the skimpy suit until you're taking burn damage, light yourself on fire, you'll begin cooling down.

When did the problem start happening: Probably whenever on_fire people stopped checking for ambient heat. Likely forever.

Possibly related stuff (which gamemode was it? What were you doing at the time? Was anything else out of the ordinary happening?): This doesn't come up outside of slime fireproofing potions because firesuits cover everything except the head, same with fireproof hardsuits. A firesuit and helmet satisfies both the on_fire state and the !on_fire state of being fireproof.

github-actions[bot] commented 2 months ago

This issue either requires verification or is unreproducible, but has had no updates for 60 days. Please provide an update within 14 days or this issue will be closed. If you believe this is a mistake, please contact an issue manager on Discord.

github-actions[bot] commented 2 months ago

This issue was marked as stale, yet no changes have been observed in the specified time. The issue has been closed.