search

ParadiseSS13 / Paradise

Paradise Station's GitHub main repository.
https://www.paradisestation.org/forum
GNU Affero General Public License v3.0
406 stars 1.2k forks source link

Unlimited Range Pointing #13772

Closed Drobe50 closed 1 year ago

Drobe50 commented 4 years ago

Issue Description: Infinite Range Pointing

What did you expect to happen: Not being able to point through the entertainment console.

What happened instead: You can point from any range with the Librarians camera and a entertainment monitor.

Why is this bad/What are the consequences: You can point anywhere you aren't.

Steps to reproduce the problem: Turn on librarians camera, go to entertainment monitor, point anywhere on screen.

When did the problem start happening: Unknown

Extra information: Other players can see the pointing, probably the chat message of who pointed as well.

stylemistake commented 4 years ago

Was anyone able to see you pointing through cameras? If not, I don't see the issue, because you're essentally just pointing at the screen.

Drobe50 commented 4 years ago

Was anyone able to see you pointing through cameras? If not, I don't see the issue.

Actually they can, it's not just a "Clientside" thing. I forgot to mention that.

stylemistake commented 4 years ago

Oh, I thought tgui camera consoles were merged here.

Contrabang commented 1 year ago

I believe this has been fixed because I am not able to reproduce it with any of the current cameras, you're only able to point to areas in your current vision through cameras. However, I am not sure what PR fixed this possibly #19072? Leaving this open for a while to see if I can get any confirmations on this

Contrabang commented 1 year ago

Discussion with other devs leads me to believe this has been fixed, as its not reproduceable anymore. Likely when the range/view check was added for pointing (which I cannot find where it was).