search

ParadiseSS13 / Paradise

Paradise Station's GitHub main repository.
https://www.paradisestation.org/forum
GNU Affero General Public License v3.0
397 stars 1.19k forks source link

Colorblind Disability not working #14552

Open Asmerath opened 4 years ago

Asmerath commented 4 years ago

Issue Description:

Colorblind Disability selectable at character creation does not effect in game vision.

What did you expect to happen:

Selectable disabilities at character creation should actually function.

What happened instead:

I selected colorblind disability at character creation and in game I can see colors. However in the body scanner it shows that I am colorblind.

Why is this bad/What are the consequences:

None that I can see, but I would like to see the game as intended through colorblind eyes.

Steps to reproduce the problem:

at character creation select the colorblind disability, join the game and see you can still see color.

When did the problem start happening:

not sure, I remember some three or so months ago on my one character it was working. I stoped playing that character and just recently selected colorblind disability again to see its broken.

Extra information:

If you think that maybe the disability didn't take at round start, go to a body scanner. The body scanner shows you as colorblind even though you can see just fine.

moxian commented 3 years ago

Can't reproduce on a local server:

dreamseeker-20201017-183054 dreamseeker-20201017-183348

What species are you playing as? Do you happen to have cybernetic eyes? Anything else which might be related? Can you share screenshots?

Asmerath commented 3 years ago

so I went through and tested colorblind on every race. It works on all of them except Slime People and IPC.

IPC Slime

Asmerath commented 3 years ago

also noticed Vulp and Taj colorblind is not true colorblind, this isnt a problem but something I found neat.

moxian commented 3 years ago

I see, thanks!

So, the problem here is that colorblind color shift is tied to the eyes: https://github.com/ParadiseSS13/Paradise/blob/668932c25693b5f2a135cba557a4dab80f533a2a/code/modules/surgery/organs/eyes.dm#L10 Slimes have no eyes Maybe disallow them from selecting colorblindness in the disabilities menu?

IPC have eyes, but those are cybernetic. And we declare cybernetic eyes to be exempt from colorblindness. https://github.com/ParadiseSS13/Paradise/blob/668932c25693b5f2a135cba557a4dab80f533a2a/code/modules/surgery/organs/eyes.dm#L33-L36

And even though the color shift is governed by the eyes,the colorblindness itself is tied to your DNA (not the eyes!). We cannot both have cybernetic eyes curing colorblindness AND allow IPCs to be colorblind (at least not without major refactoring).

The way it currently works, if you are a colorblind human, and get vulp eyes - you stay colorblind, but now see things in different hues than a human would. Yet getting eyes from a different human (who's not colorblind) would not cure colorblindness. Which is.. weird..

Honestly, I'd say moving colorblind trait from DNA to eyes organ would be a good thing. But, again, would probably be a significant code change.

P.S.: Nevermind. Reading the code more carefully i see that colorblindness is "carried" in the eyes already, and the mutation gets added and deleted appropriately. So transplanting eyes from a colorblind person onto a non-colorblind one would give the latter a colorblind mutation to the genes. See https://github.com/ParadiseSS13/Paradise/blob/668932c25693b5f2a135cba557a4dab80f533a2a/code/modules/surgery/organs/eyes.dm#L47 and below.

Asmerath commented 3 years ago

I would love to have colorblind on slimes, my character is already invested in this role play as is I would love to have a way to actually BE colorblind so I don't make certain mistakes like "They were in a red jumpsuit" when I'm not supposed to be able to see color.

KasparoVy commented 3 years ago

When Krausus & I did colourblindness back in https://github.com/ParadiseSS13/Paradise/pull/6123 it was designed so, although colourblindness is tied to DNA, it could be cured by getting a new set of eyes, or someone could gain it by getting a colourblind person's eyes.

Not sure what/when/why that broke

Asmerath commented 3 years ago

thinking the problem here is the fact that colorblind is a DNA trait that is tied to the eyes its not showing as colorblind on slimes and IPC due to the lack of organic eyes. But I would love for this to be a DNA trait and not rely on needing organic eyes to be colorblind. This way you could RP an irreparably damaged IPC or a slime person who can't see color. (not sure the lore reason as to why they can see if the first place if they don't have eyes.)