Closed farie82 closed 3 years ago
Steps to reproduce:
The issue is that roundstart "Robot" borgs have a brainmob with empty name. Stacktrace of that is roughly: https://github.com/ParadiseSS13/Paradise/blob/56752b0e78eace31c753612c26e6567b2397bc82/code/modules/mob/living/carbon/brain/robotic_brain.dm#L91-L95 https://github.com/ParadiseSS13/Paradise/blob/56752b0e78eace31c753612c26e6567b2397bc82/code/modules/mob/transform_procs.dm#L93-L98
Note that mmi is freshly-created with a freshly-created brain with a freshly-created nameless dna https://github.com/ParadiseSS13/Paradise/blob/56752b0e78eace31c753612c26e6567b2397bc82/code/modules/mob/living/carbon/brain/robotic_brain.dm#L200-L208
Ideally this should be solved by refactoring the whole mmi conscious system. Like, right now all robots seem to have two mmis in them (one from robot /new , another - freshly inserted in the Robotize proc).
Less invasive approach would be to just remove the /obj/item/mmi/robotic_brain/transfer_identity
override and let just the base /obj/item/mmi/transfer_identity
handle it, but i'm not sure if that would break something. Scary code!
Not actually fully fixed. See my comment on https://github.com/ParadiseSS13/Paradise/pull/14991
Issue Description:
What did you expect to happen: It not to runtime
What happened instead: It runtimes. Unsure what the effects are functionally
Why is this bad/What are the consequences: Runtimes are bad
Steps to reproduce the problem:
When did the problem start happening: TGUI version of the orbit menu. Runtime observed around 14:00 7/11/2020