ParadiseSS13 / Paradise

Paradise Station's GitHub main repository.
https://www.paradisestation.org/forum
GNU Affero General Public License v3.0
405 stars 1.21k forks source link

Body Markings cover Prosthetics #16509

Open roarbark opened 3 years ago

roarbark commented 3 years ago

Issue Description: vulpkanin, here specifically, render body markings like the "Vulpkanin Points" above prosthetics on the sprite

What did you expect to happen: the prosthetic to not have the body marking put ontop of it- maybe there could be just a one-limbed version of the body marking or something- some of the prosthetics look different than actual spaceman legs afterall

What happened instead: the prosthetic is covered by the body marking. it's a shame since they look actually kinda cool

Why is this bad/What are the consequences: it looks strange

Steps to reproduce the problem: choose a body colouration option from "body markings", choose a prosthetic

When did the problem start happening: has been in place since i've started playing, likely since vulps have been a thing

Extra information: green

here the vulp points in green, over mostly white prosthetics (different ones) on black fur

KasparoVy commented 3 years ago

Because markings here have their own layer and are not applied on a per-limb basis during organ icon generation like on Virgo, the 'quick fix' would be to have one-limbed versions of markings like roar described

Otherwise it'd require an overhaul and adaption to Virgo's char creation & icon generation system since that allows not only for toggling whether markings appear on synthetic parts, but also renders the markings on the bodyparts themselves instead of on a layer above, on top of granting the ability to independantly colour roboparts from your fleshy body

This would also most likely require switching to multiplicative colour blending/images+the colour property of an atom & whitesprites instead of blacksprites for additive blending using icon objects