search

ParadiseSS13 / Paradise

Paradise Station's GitHub main repository.
https://www.paradisestation.org/forum
GNU Affero General Public License v3.0
405 stars 1.21k forks source link

Reviving IPC's after positronic brain damage seems broken #18726

Open streather opened 2 years ago

streather commented 2 years ago

Issue Description:

Upon taking damage due to shock ipc's can die due to excessive damage to their positronic brains, however, it seems that despite being fully repaired externally, and having surgery to repair the brain, IPC's remain dead.

Removing and reinstalling the brain seems to reboot them as does hitting them.

What did you expect to happen:

Once fully repaired the ipc should get revived

What happened instead:

Instead of getting revived upon a full repair of the positronic brain, you remain offline until someone removes the brain from the body and reinserts it, or you take damage of some sort.

Why is this bad/What are the consequences:

It's more of an annoyance and inconsistency really, if after taking excessive damage you need to remove and reinstall the brain to effectively "reboot" an IPC than that seems fair enough, but these seems more of a bug due to the recent damage refactor than a feature.

Plus the revive on damage part doesn't make sense.

Steps to reproduce the problem:

Be an IPC and get shocked enough to die due to brain damage. (both times it's happened so far took 2 shocks) Get someone to repair you.

When did the problem start happening:

I've only noticed it yesterday but it seems related to the damage refactor I think.

Extra information:

KittyNoodle commented 2 years ago

This also might be caused by the fact that the ipc player is not alerted when revived, leading to them just wandering around as a ghost not knowing they are alive