ParadiseSS13 / Paradise

Paradise Station's GitHub main repository.
https://www.paradisestation.org/forum
GNU Affero General Public License v3.0
397 stars 1.19k forks source link

A Couple Powerfist Bugs #18959

Open Leanfrog opened 2 years ago

Leanfrog commented 2 years ago

What is the problem:

  1. Placing an air tank on a powerfist while it is in your bag does not apply nodrop to it.
  2. You can walk out of the knockback from the punches of the powerfist.

What did you expect to happen:

  1. For the powerfist to become nodrop regardless of where it had the tank attached.
  2. For the victim to not be able to walk out of the knockback from the punch.

What happened instead:

  1. The powerfist did not gain nodrop when it had a tank equipped while it was in a bag.
  2. The victim was able to walk against the knockback of the powerfist, additionally the victim could even slam themselves into the puncher if they were close enough and timed it right.

Why is this bad/What are the consequences:

  1. It's odd and can "punish" players for doing something that would be seen as perfectly rational by not giving the nodrop when it should.
  2. Knockback should work as intended and not be resistable by just walking, also being able to slam yourself into the attacker shouldn't be a thing.

Steps to reproduce the problem:

  1. Put a powerfist in your bag, then equip an oxygen tank to it, notice it doesn't have nodrop when removed and you can just toss it around freely.
  2. Punch a target with a powerfist that has a filled air tank the target must be capable of moving, have the target walk against the direction of the knockback, notice that they are able to resist the knockback and even slam into the powerfist user if they're directly adjacent.

When did the problem start happening: N/A

Christer2222 commented 1 year ago

Encountered the tank-in-bag bug myself

Spaghetti-bit commented 2 months ago

The tank in bag is not a bug and is intended as far as I’m aware.

Christer2222 commented 2 months ago

The tank in bag is not a bug and is intended as far as I’m aware.

I disagree, it feels very awkward that you can put a tank inside the fist while it is in your bag, and then surprise attack someone with it. The powerfist is a very loud and visible weapon, if you want to use it, then it needs to be on your hand. If it really is intended, there should be a line on examine saying something like "putting a gas tank in the powerfist while it is in your bag loosens your grip enough on it to allow you to equip and unequip it at will without the tools needed". Imo stealth attacking with a powerfist might even be considered an exploit.

github-actions[bot] commented 2 weeks ago

This issue either requires verification or is unreproducible, but has had no updates for 60 days. Please provide an update within 14 days or this issue will be closed. If you believe this is a mistake, please contact an issue manager on Discord.

DGamerL commented 2 weeks ago

Tank in bag is a bug.