search

ParadiseSS13 / Paradise

Paradise Station's GitHub main repository.
https://www.paradisestation.org/forum
GNU Affero General Public License v3.0
407 stars 1.21k forks source link

Blob organ destruction runtimes [PL] #19631

Open GDNgit opened 2 years ago

GDNgit commented 2 years ago 
[2022-11-07T12:38:54] Runtime in garbage.dm,361: /obj/item/organ/external/hand destroy proc was called multiple times, likely due to a qdel loop in the Destroy logic
[2022-11-07T12:38:54]   proc name: qdel (/proc/qdel)
[2022-11-07T12:38:54]   src: null
[2022-11-07T12:38:54]   call stack:
[2022-11-07T12:38:54]   qdel(Xion Manufacturing Group left ... (/obj/item/organ/external/hand), 0)
[2022-11-07T12:38:54]   Xion Manufacturing Group left ... (/obj/item/organ/external/hand): blob act(the blob (/obj/structure/blob/normal))
[2022-11-07T12:38:54]   the blob (/obj/structure/blob/normal): Crossed(Xion Manufacturing Group left ... (/obj/item/organ/external/hand), null)
[2022-11-07T12:38:54]   Xion Manufacturing Group left ... (/obj/item/organ/external/hand): forceMove(the floor (160,122,2) (/turf/simulated/floor/plasteel))
[2022-11-07T12:38:54]   Xion Manufacturing Group left ... (/obj/item/organ/external/hand): remove(Jason Ford (/mob/living/carbon/human), 1)
[2022-11-07T12:38:54]   Xion Manufacturing Group left ... (/obj/item/organ/external/hand): remove(Jason Ford (/mob/living/carbon/human), 1)
[2022-11-07T12:38:54]   Xion Manufacturing Group left ... (/obj/item/organ/external/hand): remove(Jason Ford (/mob/living/carbon/human), 1)
[2022-11-07T12:38:54]   Xion Manufacturing Group left ... (/obj/item/organ/external/hand): Destroy(0)
[2022-11-07T12:38:54]   Xion Manufacturing Group left ... (/obj/item/organ/external/hand): Destroy(0)
[2022-11-07T12:38:54]   qdel(Xion Manufacturing Group left ... (/obj/item/organ/external/hand), 0)
[2022-11-07T12:38:54]   ...
[2022-11-07T12:38:54]   Xion Manufacturing Group left ... (/obj/item/organ/external/arm): receive damage(12.688, 0, 0, null, /list (/list), 1, 1)
[2022-11-07T12:38:54]   the upper body (/obj/item/organ/external/chest): receive damage(15, 0, 0, null, /list (/list), 0, 1)
[2022-11-07T12:38:54]   Jason Ford (/mob/living/carbon/human): apply damage(15, "brute", null, 0, 0, null, 0)
[2022-11-07T12:38:54]   the blob (/obj/structure/blob/normal): chemical attack(the floor (160,122,2) (/turf/simulated/floor/plasteel))
[2022-11-07T12:38:54]   the blob (/obj/structure/blob/normal): Pulse(7, 2, "#808000")
[2022-11-07T12:38:54]   the blob node (/obj/structure/blob/node): Pulse(5, 1, "#808000")
[2022-11-07T12:38:54]   the blob node (/obj/structure/blob/node): process(20)
[2022-11-07T12:38:54]   Objects (/datum/controller/subsystem/processing/obj): ignite(0)
[2022-11-07T12:38:54]   Master (/datum/controller/master): Loop()
[2022-11-07T12:38:54]   Master (/datum/controller/master): StartProcessing(0)

Steps to reproduce the problem: Likely just have a blob smack it

When did the problem start happening: This occures on other things as well, such as #19059

Sirryan2002 commented 2 years ago

this is because blob act calls qdel