search

ParadiseSS13 / Paradise

Paradise Station's GitHub main repository.
https://www.paradisestation.org/forum
GNU Affero General Public License v3.0
407 stars 1.21k forks source link

As a carded AI, when the SM crystal delaminates, if your holder is in a locker, you get a message about holding onto yourself #20473

Open Christer2222 opened 1 year ago

Christer2222 commented 1 year ago

Issue Description:

You get a message meant for your holder as a carded AI, if they hide in a locker during a SM delamination and are holding you.

What did you expect to happen:

To not get that message. Maybe something else like "you're being hold onto" if anything.

What happened instead:

I got someone else's message.

Why is this bad/What are the consequences:

People should only see messages meant for them.

Steps to reproduce the problem:

  1. Be AI.
  2. Get carded.
  3. Have your holder hide in a locker, holding you.
  4. Have the SM crystal delaminate.

When did the problem start happening:

Noticed today 22.02.2023

Extra information:

I am in the intellicard, the AI. image

warriorstar-orion commented 1 year ago

Considering the placeholder there is the mob's location, my hunch is that it says this whenever an AI is in a card, regardless of whether they're also in a locker. All players get that message (or the "You feel reality distort for a moment..." message if not in a locker (or technically any container)). There should probably be a different message for carded AIs.