ParadiseSS13 / Paradise

Paradise Station's GitHub main repository.
https://www.paradisestation.org/forum
GNU Affero General Public License v3.0
397 stars 1.19k forks source link

AI can toggle on AI Remote Control setting in bots interface #23828

Open FunnyMan3595 opened 8 months ago

FunnyMan3595 commented 8 months ago

Exploit Reports

BYOND Version

515.1619

Issue Description

When you open up the interface of a small bot (Beepsky, etc) as an AI, you're able to toggle on the AI Remote Control setting.

Honestly, it's not particularly clear what this setting is supposed to do. I've noticed that it does disable the Call button in Access Robot Control, and at least one of the mentors thinks it should stop you from controlling a bot that's not in camera view, which I can't confirm or deny easily.

What did you expect to happen?

AI can't give themselves control

What happened instead?

AI can give themselves control

Why is this bad/What are the consequences?

It's at very least counter-intuitive for a setting with this name to be toggled on by the AI without significant effort. And potentially a bug.

Steps to reproduce the issue.

Become AI Open Access Robot Control Open a bot's interface Toggle AI Remote Control off Toggle AI Remote Control back on Profit

When did the problem start happening?

Unknown

Extra information

No response

Relevant log output/runtime error

No response

Oyu07 commented 8 months ago

In code

var/remote_disabled = FALSE //If enabled, the AI cannot Remotely control a bot. It can still control it through cameras

So it seems intentional that you are able to interact with them if you see them.

Henri215 commented 7 months ago

In code

var/remote_disabled = FALSE //If enabled, the AI cannot Remotely control a bot. It can still control it through cameras

So it seems intentional that you are able to interact with them if you see them.

Do you think theres anything that should be done here?