ParadiseSS13 / Paradise

Paradise Station's GitHub main repository.
https://www.paradisestation.org/forum
GNU Affero General Public License v3.0
403 stars 1.2k forks source link

Capture groups make regex highlights fail #25787

Open CinnamonSnowball opened 4 months ago

CinnamonSnowball commented 4 months ago

Exploit Reports

BYOND Version

515.1639

Issue Description

Using capture groups in a regex highlight seems to break it completely, failing to highlight anything

What did you expect to happen?

One of the most useful features of regex highlights vs. plaintext ones to function

What happened instead?

2024-06-04 02_08_22

Why is this bad/What are the consequences?

Regression from our previous chat system

Steps to reproduce the issue.

See screencap above

When did the problem start happening?

Haven't checked to make sure but I'll be damned if it wasn't introduced in the TGUI chat port

Extra information

Thanks, have a Paradise day!

Relevant log output/runtime error

No response

chuga-git commented 4 months ago

This sucks, but TG chat purposefully restricts the symbols allowed in regex highlight strings.

github-actions[bot] commented 2 months ago

This issue either requires verification or is unreproducible, but has had no updates for 60 days. Please provide an update within 14 days or this issue will be closed. If you believe this is a mistake, please contact an issue manager on Discord.

github-actions[bot] commented 1 month ago

This issue was marked as stale, yet no changes have been observed in the specified time. The issue has been closed.

CinnamonSnowball commented 1 month ago

This sucks, but TG chat purposefully restricts the symbols allowed in regex highlight strings.

And what is that purpose? We didn't use to do this and our highlights worked fine

Contrabang commented 2 weeks ago

We when switched chat systems, this regressed to not having regex available. Ideally, we bring this feature back.