ParadiseSS13 / Paradise

Paradise Station's GitHub main repository.
https://www.paradisestation.org/forum
GNU Affero General Public License v3.0
393 stars 1.17k forks source link

Semi auto guns fire on mouse button release.... #25824

Open Komrad822 opened 3 months ago

Komrad822 commented 3 months ago

Exploit Reports

BYOND Version

515.1640

Issue Description

Semi auto weapons fire on click release instead of on click. This doesn't seem right.

What did you expect to happen?

When i click, i fire.

What happened instead?

When I click and hold, I do not shoot and only shoot on release.

Why is this bad/What are the consequences?

This could mainly have issues for people with poor latency or hindered motor skills I feel.

Steps to reproduce the issue.

  1. Have semi auto weapon
  2. click and hold
  3. release

When did the problem start happening?

Either with #25267 or #25520

Extra information

Tested using various semi auto guns but not all. But the vast majority of the ones I used are ones we WOULD see in a round. Found it while testing an earlier issue using a pulse rifle and unica.

Relevant log output/runtime error

No response

matttheficus commented 2 months ago

This is cursed and really bad. Also likely a BYOND thing.