search

ParadiseSS13 / Paradise

Paradise Station's GitHub main repository.
https://www.paradisestation.org/forum
GNU Affero General Public License v3.0
385 stars 1.15k forks source link

Robotic brains that has had the client ghost out of(?) bricks them #25940

Open 1080pCat opened 3 weeks ago

1080pCat commented 3 weeks ago

Exploit Reports

BYOND Version

515.1639

Issue Description

After a client ghosts out of a robotic brains, if reactivated, ghosts attempting to join as the brain becomes the brain, then instantly dies, making the robotic brain their new body, but not actually letting them be the brain

What did you expect to happen?

It to work

What happened instead?

Joining in as the brain pretty much made me re-enter a dead brain

image

Why is this bad/What are the consequences?

broken

Steps to reproduce the issue.

  1. join as a robotic brain, and ghost out of it
  2. have the brain reactivated
  3. have another(??) client attempt to join as the brain

When did the problem start happening?

when the robotic brain ghosting pr was merged

Extra information

Im running on alot of assumptions as this isn't really easily to test locally.

Relevant log output/runtime error

No response

BiancaWilkson commented 1 week ago

Do you know if the brain was damaged in any way before reactivation? I notice this happen when something like an ash storm deals enough damage to flatline the robobrain.