ParadiseSS13 / Paradise

Paradise Station's GitHub main repository.
https://www.paradisestation.org/forum
GNU Affero General Public License v3.0
383 stars 1.15k forks source link

General Air Control circuit boards are unprintable #25991

Closed YoureNotTheSharpest closed 1 day ago

YoureNotTheSharpest commented 1 week ago

Exploit Reports

BYOND Version

515.1620

Issue Description

the General Air Alarm is unprintable, when it's attempted to be printed an Atmospherics Monitor is printed instead

What did you expect to happen?

To get a General Air Alarm board

What happened instead?

I was given the wrong board and there is now a finite amount of General Air Control Consoles

Why is this bad/What are the consequences?

at the best its just two recipies in the circuit inprinter printing the same thing, at worst it makes it impossible to make General Air Control Consoles.

Steps to reproduce the issue.

Get your levels in the RND console Go print General Air Alarm in circuit imprinter Get an Atmospherics Monitor

When did the problem start happening?

N/A

Extra information

I genuinely think I am the first person to fuckin attempt to print a General Air Control Board.

Relevant log output/runtime error

No response

pwbokie commented 1 week ago

You pointed this out to me in-game! I'm gonna take a look and see if I can fix it.

pwbokie commented 1 week ago

Okay, I believe the actual issue is that the two circuit imprinter options General Air Control and Atmospherics Monitor print the same thing: a "circuit board (Atmospheric Monitor)". As far as I can tell, there isn't any such thing as an Atmospherics Monitor console OR a General Air Control console - only an "Air Sensor Monitor". Putting the aforementioned circuit board into a machine frame results in an Air Sensor Monitor.

My proposed fix is to remove both of these entries from the circuit imprinter, replacing them with an entry titled "Circuit Board (Air Sensor Monitor)", which would print a "circuit board (Air Sensor Monitor)", an item which would completely replace the "circuit board (Atmospheric Monitor)".

This was as hard to write as it probably is to read. Sorry.