CE Blueprint Picture doesnt count for objective

[Banderblitz]

Exploit Reports

• [X] I confirm this issue is not an exploit. (Required)

BYOND Version

515.1620

Issue Description

After end of round the CE blueprint picture in my box did not count for the objective.

What did you expect to happen?

I expected the objective that explicitly states to count when a picture is taken for the objective to complete.

What happened instead?

The blueprint picture did not count and thus the objective failed.

Why is this bad/What are the consequences?

Objectives not working as intended goes against the point of an antag attempting to complete them.

Steps to reproduce the issue.

1. Roll antag with CE blueprint objective
2. Take Picture of the blueprints
3. Wait for round to end
4. Redtext

When did the problem start happening?

As of round 40929 on 7/3/2024

Extra information

It could specifically be that said picture was in a box and thus the objective fails not being in your "bag" as the blueprints are normally a large item that cannot fit in the box.

Relevant log output/runtime error

No response

[tipoima]

Tested it locally:

Greentext: Photo held in hands Photo held in pocket Photo in a traitor belt (in a backpack) Photo in a paradox bag (on the back) Photo in a modsuit storage Photo in a modsuit storage in a bag of holding

Redtext: Photo in Skrell's headpocket Photo in a zipped dufflebag Photo in a military belt (in belt slot)

[wanderso]

More than that. I just tested stealing the advanced medical hypospray and smuggling it out in a Skrell headpocket. That also redtexts. It seems that the code doesn't check inside Skrell headpockets for stuff.