ParadiseSS13 / Paradise

Paradise Station's GitHub main repository.
https://www.paradisestation.org/forum
GNU Affero General Public License v3.0
397 stars 1.19k forks source link

"Local" TGUI chat tab still shows global chats if GhostEars is on #26169

Open warriorstar-orion opened 2 months ago

warriorstar-orion commented 2 months ago

Exploit Reports

BYOND Version

515.1641

Issue Description

Checking "Local" for a TGUI chat tab still shows chats from everywhere if GhostEars is enabled.

What did you expect to happen?

Local chat filtering should filter to local chat.

What happened instead?

It didn't.

Why is this bad/What are the consequences?

It's annoying because it doesn't do what it purports to.

Steps to reproduce the issue.

Be a ghost in round, turn GhostEars on, add a chat tab, set it to Local only, observe being able to hear chat from the entire world.

When did the problem start happening?

Probably since TGUI chat was introduced.

Extra information

No response

Relevant log output/runtime error

No response

AyIong commented 2 months ago

That's what's responsible for the hearing range of ghosts. TGchat tabs cannot have different values for these parameters, they are common to everything

image

warriorstar-orion commented 2 months ago

Then "Local" is probably a misnomer, and the tab should be renamed to "Chat".