ParadiseSS13 / Paradise

Paradise Station's GitHub main repository.
https://www.paradisestation.org/forum
GNU Affero General Public License v3.0
405 stars 1.21k forks source link

Unable to replace roundstart carpet/grass tiles with normal floor #26234

Open Monkeke2 opened 4 months ago

Monkeke2 commented 4 months ago

Exploit Reports

BYOND Version

515.1641

Issue Description

Replacing tiles that were carpet/grass roundstart with normal floortiles just makes bare plating, although it does hide wires/pipes for some reason. The floortile can later be removed and replaced with carpet/grass (interchangable for some reason) and work fine.

What did you expect to happen?

Normal floortile to be put in place

What happened instead?

Bare plating appeared, although hiding wires

Why is this bad/What are the consequences?

Not really too bad, just it shouldn't be happening

Steps to reproduce the issue.

1) crowbar something like carpet in NTR's office 2) put floortiles on the pried tile 3) apply eyes

When did the problem start happening?

Noticed it happen like half a year ago, didnt care to report

Extra information

I haven't tried completely disassembling the plating and then rebuilding it

Relevant log output/runtime error

No response

Scribble-Sheep commented 4 months ago

I've ran into this when remodeling the chapel. Using a floorpainter on the tile fixes it.

Kenionatus commented 1 month ago

27104 and the subsequent removal of floors that are colored by mapping icon states should allow removal of the code that causes this bug when it's done.

The issue is that floor turf remember their previus icon state so colored floor stays colored after replacement. This doesn't work with carpet because carpet has a different icon file.