ParadiseSS13 / Paradise

Paradise Station's GitHub main repository.
https://www.paradisestation.org/forum
GNU Affero General Public License v3.0
405 stars 1.2k forks source link

Mute Sound Making #26376

Open LgMark2200-2Point0 opened 2 months ago

LgMark2200-2Point0 commented 2 months ago

Exploit Reports

BYOND Version

515.1642

Issue Description

While making Emote Sounds, like Snapping or some other Emotes, it is shown in Chat as Making trying to make a Sound, unsure if this is a Intended way, or a Oversight. obraz_2024-08-02_225404732

What did you expect to happen?

I expected to see Emote Text in Chat. obraz_2024-08-02_225624125

What happened instead?

I see my Character trying to make a Sound. obraz_2024-08-02_225455725

Why is this bad/What are the consequences?

It's a Roleplay Issue I could see.

Steps to reproduce the issue.

Have a Mute Character, and Emote something like Snapping your Fingers.

When did the problem start happening?

02.08.2024 (D/M/Y), though it could have been for a VERY long Time now.

Extra information

No response

Relevant log output/runtime error

No response

Sirryan2002 commented 2 months ago

Bug here is that people who have the "MUTE" disability selected have the MUTE trait which is also used in a combat/balance sense to quiet people from being able to make noises/emote audibly. Theoretically this shouldn't block things like snapping and is not intended behavior

// Whether the mob is capable of talking
/mob/living/can_speak()
    if(HAS_TRAIT(src, TRAIT_MUTE))
        return FALSE
    if(is_muzzled())
        var/obj/item/clothing/mask/muzzle/M = wear_mask
        if(M.mute >= MUZZLE_MUTE_MUFFLE)
            return FALSE
    return TRUE

This is going to need a minor refactor to fix