ParadiseSS13 / Paradise

Paradise Station's GitHub main repository.
https://www.paradisestation.org/forum
GNU Affero General Public License v3.0
405 stars 1.21k forks source link

Janitor's Cart not able to hold all signs #26555

Open Asmerath opened 3 months ago

Asmerath commented 3 months ago

Exploit Reports

BYOND Version

515.1640

Issue Description

Tried putting wet floor signs into janitors cart and ended up not able to.

What did you expect to happen?

I expected to be able to put my wet floor signs into my janitors cart

What happened instead?

I was putting a clone of a sign into the cart causing it to be full while only holding 1 sign

Why is this bad/What are the consequences?

Unable to carry my signs around may lead to me being sad.

Steps to reproduce the issue.

Approach the locker of janitors supplies Alt+Click the tile to see all of it Make sure your cart is next to you for ease of access and speedy stocking Click the wet floor sign and add it to the cart Notice there still shows 4 signs on the tile and click the same sign again. Do this 4 times to fill your cart Notice that after removing 1 sign there are no more in your cart The sprite shows 3 more and adding the one you took shows 4 Unable to add more signs because the cart thinks its full Unable to remove the other signs because they are duplicates and not real. Cry and get demoted because you made a wet floor on red

When did the problem start happening?

I'm not too sure, just started playing janitor recently.

Extra information

No response

Relevant log output/runtime error

No response

Burzah commented 2 months ago

Tested this today. It looks like the cart is functioning as intended, by using the new radial menu when clicking on it to remove stuff from the cart. The sprite does update properly in regards to how many signs there are in the cart. The thing that does not work properly right now is that when you Shift + Click to examine the cart, it shows as nothing. So that will need to be fixed at some point.