ParadiseSS13 / Paradise

Paradise Station's GitHub main repository.
https://www.paradisestation.org/forum
GNU Affero General Public License v3.0
397 stars 1.19k forks source link

Creating / deleting a security record doesn't automatically update the manifest #26581

Open Daylight2 opened 3 weeks ago

Daylight2 commented 3 weeks ago

Exploit Reports

BYOND Version

515.1633

Issue Description

The manifest goes off of whether someone has a security record or not. However, the manifest doesn't update based on this until the manifest is updated by other means, usually someone joining or leaving the round, which can lead to considerable delay.

What did you expect to happen?

Creating / deleting a sec record updating the manifest right away.

What happened instead?

The AI continued murdering the person because they weren't on the manifest yet.

Why is this bad/What are the consequences?

Manifest changes should happen right away.

Steps to reproduce the issue.

When did the problem start happening?

Likely forever

Extra information

No response

Relevant log output/runtime error

No response

AffectedArc07 commented 3 weeks ago

Manifest pulls from general record not security records.

Daylight2 commented 3 weeks ago

Well, the issue still applies either way.