ParadiseSS13 / Paradise

Paradise Station's GitHub main repository.
https://www.paradisestation.org/forum
GNU Affero General Public License v3.0
397 stars 1.18k forks source link

Non-Antag Tajarans can hear AOOC on Revolution?? #26588

Open Coolrune206 opened 3 weeks ago

Coolrune206 commented 3 weeks ago

Exploit Reports

BYOND Version

515.1639

Issue Description

Ran revolution. Used AOOC to contact revos. Several non-antags LOOC'd that they could see it. Both were Tajarans (one explorer, one assistant).

What did you expect to happen?

Non-antags should not see Antagonist OOC.

What happened instead?

Two tajarans could see AOOC as non-antagonists.

Why is this bad/What are the consequences?

The goddamn Tajarans now think they're always antagonists.

More seriously, AOOC should be seen by... antags only.

Steps to reproduce the issue.

Run Revos. Have a headrev and some revos. Use AOOC. Have the goddamn felinids - I mean, Khajits - I mean, Tajarans able to see AOOC. They are not antags.

When did the problem start happening?

No goddamn idea to be honest. Rare enough to see rev rounds, so if the issue is tied to revolution being poorly defined in terms of where AOOC is seen, then it could have been a while since this started.

Extra information

No response

Relevant log output/runtime error

No response

1080pCat commented 3 weeks ago

did you check if the two tarj were x revs? its possible that de converted revs can still hear AOOC rather than it being species dependent

Coolrune206 commented 3 weeks ago

Someone mentioned in coding chat it was how the gamemode picks revs, or something: It will set a flag on the maximum number of headrevs that the gamemode can generate, then check the station population and assign head revs respectively. So these two random people (on a round with one headrev) were probably the other two headrevs that would have been picked if the pop was higher. Apparently, even despite not being "activated" due to the lower pop, they were still flagged as antags for AOOC?