ParadiseSS13 / Paradise

Paradise Station's GitHub main repository.
https://www.paradisestation.org/forum
GNU Affero General Public License v3.0
403 stars 1.2k forks source link

Library books with a rating outside the 1-10 rating system #27037

Open Truls20 opened 1 week ago

Truls20 commented 1 week ago

Exploit Reports

BYOND Version

515.1642

Issue Description

There were books in the library computer with a rating higher than 10 Image

What did you expect to happen?

All books in the library computer to have a rating between 1 and 10 (or 0 for unrated ones)

What happened instead?

Two books in the library computer had a rating of 246913000 and 90702900

Why is this bad/What are the consequences?

A brief essay on the life of the Xenomorph by Doug Wall and An interview with CMO Rodrigo Greene by Patrick Brown are not that good

Steps to reproduce the issue.

It appeared at once when I checked the library computer, those are the books with SSID 1 and 2

When did the problem start happening?

It was the 9th of October 13 o clock server time, round 42128

Extra information

No response

Relevant log output/runtime error

No response

Adrer commented 1 week ago

Was fixed in #26904 , however, rogue values still remain in the database. Will keep this open until the rogue values are removed from the database.