ParadiseSS13 / Paradise

Paradise Station's GitHub main repository.
https://www.paradisestation.org/forum
GNU Affero General Public License v3.0
403 stars 1.2k forks source link

Frequent Janitor Runtimes #27132

Open Erikos66 opened 5 hours ago

Erikos66 commented 5 hours ago

Exploit Reports

BYOND Version

515.1644

Issue Description

Recently quite a few runtimes have been spitting out of either bubblegum, decal or janitor or all of the above, hard to tell. 💀

What did you expect to happen?

No runtiming for anything, EVER.

What happened instead?

It runtimed.

Why is this bad/What are the consequences?

Runtimes bad.

Steps to reproduce the issue.

Not quite sure of the exact cause, runtime posted below.

When did the problem start happening?

First noticed it on shift 42244

Extra information

No response

Relevant log output/runtime error

[2024-10-19T06:46:05] Runtime in code/datums/atom_hud.dm:68: bad index
   proc name: remove from single hud (/datum/atom_hud/proc/remove_from_single_hud)
   src: /datum/atom_hud/data/janitor (/datum/atom_hud/data/janitor)
   call stack:
   /datum/atom_hud/data/janitor (/datum/atom_hud/data/janitor): remove_from_single_hud
   /datum/atom_hud/data/janitor (/datum/atom_hud/data/janitor): remove_from_hud
   the blood (/obj/effect/decal/cleanable/blood/bubblegum): Destroy
   the blood (/obj/effect/decal/cleanable/blood/bubblegum): Destroy
   qdel(the blood (/obj/effect/decal/cleanable/blood/bubblegum), 0)
   Atoms (/datum/controller/subsystem/atoms): InitAtom
   the blood (/obj/effect/decal/cleanable/blood/bubblegum): attempt_init
   the blood (/obj/effect/decal/cleanable/blood/bubblegum): attempt_init
   the blood (/obj/effect/decal/cleanable/blood/bubblegum): New
   the bubblegum (/mob/living/simple_animal/hostile/megafauna/bubblegum): Moved
   the bubblegum (/mob/living/simple_animal/hostile/megafauna/bubblegum): Move
   the bubblegum (/mob/living/simple_animal/hostile/megafauna/bubblegum): Move
   the bubblegum (/mob/living/simple_animal/hostile/megafauna/bubblegum): Move
   the bubblegum (/mob/living/simple_animal/hostile/megafauna/bubblegum): Move
   the bubblegum (/mob/living/simple_animal/hostile/megafauna/bubblegum): handle_automated_movement
   the bubblegum (/mob/living/simple_animal/hostile/megafauna/bubblegum): handle_automated_movement
   Idling NPC Pool (/datum/controller/subsystem/idlenpcpool): fire
   Idling NPC Pool (/datum/controller/subsystem/idlenpcpool): ignite
   Master (/datum/controller/master): RunQueue
   Master (/datum/controller/master): Loop
   Master (/datum/controller/master): StartProcessing
1080pCat commented 5 hours ago

This is due to bubblegum interacting with qdel blood. Caused by #26631