ParadiseSS13 / Paradise

Paradise Station's GitHub main repository.
https://www.paradisestation.org/forum
GNU Affero General Public License v3.0
405 stars 1.21k forks source link

you can hear emotes that shouldn't be heard #27226

Open Sadboysuss opened 2 weeks ago

Sadboysuss commented 2 weeks ago

Exploit Reports

BYOND Version

515.1642

Issue Description

Image Image

What did you expect to happen?

not hearing inaudible emotes while blind

What happened instead?

I heard inaudible emotes while blind

Why is this bad/What are the consequences?

you're blind, you can't hear something that can only be seen

Steps to reproduce the issue.

  1. be blind
  2. have someone emote near you

When did the problem start happening?

I just started playing

Extra information

No response

Relevant log output/runtime error

No response

meow20 commented 2 weeks ago

How do you even fix that outside of hardcoded lines of what to show or what not to show

Sadboysuss commented 2 weeks ago

How do you even fix that outside of hardcoded lines of what to show or what not to show

just set flags of audible and visible emotes, then do checks for those

bwluera commented 2 weeks ago

There are already flags for audible and visible emotes. It seems like what you've posted is the intended behavior. Unless an experienced contributor disagrees then this falls under 'Not a bug'

Sadboysuss commented 2 weeks ago

intended behavior

Comedy.