ParadiseSS13 / Paradise

Paradise Station's GitHub main repository.
https://www.paradisestation.org/forum
GNU Affero General Public License v3.0
407 stars 1.21k forks source link

PDA Minesweeper crashes when I look at the leaderboard #27408

Closed Truls20 closed 5 days ago

Truls20 commented 5 days ago

Exploit Reports

BYOND Version

515.1642

Issue Description

When I open the Minesweeper leaderboard it crashes my PDAImage

What did you expect to happen?

For me to see the leaderboard

What happened instead?

The PDA crashed

Why is this bad/What are the consequences?

I would like for my PDA not to crash

Steps to reproduce the issue.

It happened after I had submitted my second score to the PDA leaderboard with the exact same name. Try to submit your high score twice with the same name.

When did the problem start happening?

19:00 CET 20.11.2024

Extra information

I think the issue was introduced in the following PR https://github.com/ParadiseSS13/Paradise/pull/26860

Relevant log output/runtime error

ReferenceError: 'sortOrder' is undefined
   at Anonymous function (http://127.0.0.1:52073/tgui.bundle.js:254:28839)
   at Anonymous function (http://127.0.0.1:52073/tgui.bundle.js:346:91228)
   at o (http://127.0.0.1:52073/tgui.bundle.js:346:27437)
   at B (http://127.0.0.1:52073/tgui.bundle.js:346:91493)
   at S (http://127.0.0.1:52073/tgui.bundle.js:254:28548)
   at gt (http://127.0.0.1:52073/tgui.bundle.js:1:48702)
   at fn (http://127.0.0.1:52073/tgui.bundle.js:1:50142)
   at Ke (http://127.0.0.1:52073/tgui.bundle.js:1:48868)
   at Cn (http://127.0.0.1:52073/tgui.bundle.js:1:50849)
   at qe (http://127.0.0.1:52073/tgui.bundle.js:1:51008)
User Agent: Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 6.2; WOW64; Trident/7.0; .NET4.0C; .NET4.0E; .NET CLR 2.0.50727; .NET CLR 3.0.30729; .NET CLR 3.5.30729; Zoom 3.6.0)
State: {"ckey":"truls20","interface":"PDA","window":{"key":"[0x2034818]_198731-main","size":null,"fancy":2,"locked":0}}
Burzah commented 5 days ago

Fixed with #27409

Thank you for making a report!