Fixes inconsistent behaviour between accelerated particles from the PA and the singularity.
Sometimes the particles would be bumped by the singularity and be destroyed(they called obj/effect/singularity_act()) and other time the particles would bump the singularity twice which would impart the energy twice.
This PR overrides singularity_act() on the accelerated particle effect so it just returns 0, and reduces the energy to 0 once the particles give the singularity energy.
Why It's Good For The Game
Inconsistent behaviour is bad.
Images of changes
Testing
Made a singularity, fired particle beams at it, and made sure each beam gave exactly as much energy to the singularity as it should have
Declaration
[x] I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.
Changelog
:cl:
fix: Accelerated particles now always give the singularity energy and only do so once.
/:cl:
What Does This PR Do
Fixes inconsistent behaviour between accelerated particles from the PA and the singularity. Sometimes the particles would be bumped by the singularity and be destroyed(they called obj/effect/singularity_act()) and other time the particles would bump the singularity twice which would impart the energy twice.
This PR overrides singularity_act() on the accelerated particle effect so it just returns 0, and reduces the energy to 0 once the particles give the singularity energy.
Why It's Good For The Game
Inconsistent behaviour is bad.
Images of changes
Testing
Declaration
Changelog
:cl: fix: Accelerated particles now always give the singularity energy and only do so once. /:cl: