search

ParadiseSS13 / Paradise

Paradise Station's GitHub main repository.
https://www.paradisestation.org/forum
GNU Affero General Public License v3.0
405 stars 1.2k forks source link

Switching race from IPC with prosthetics, keeps prosthetics on new race. #4105

Closed lolzyking closed 2 years ago

lolzyking commented 8 years ago

Problem Description: I'm a robot kitty with robot head chest and lower body

What did you expect to happen: not be a robot kitty

What happened instead: above

Why is this bad/What are the consequences: well head types seem important

Steps to reproduce the problem: switch race from ipc with full prosthetics to an organic race

lolzyking commented 8 years ago

brain is in the ipc head, lmao

ghost commented 8 years ago

i don't get it

ghost commented 8 years ago

oh

marlyn-x86 commented 8 years ago

Yeah, swapping species in the preferences panel doesn't revert to a sane state, so you can get fat IPCs or robo-head tajarans.

KasparoVy commented 8 years ago

Is this from start-round character setup or by accessing the character setup via the game preferences verb in the preferences tab? Every time without fail, regardless of the race I switch to or the configuration I've my prosthetic parts in, it reverts me to no prosthetics whatsoever by accessing the menu by either means. This includes starting with an IPC character loaded from SQL with the robotic parts and switching to an organic race by accessing the menu from either character setup or via the preferences tab > game preferences verb and by changing from default human to IPC, setting up the robolimbs, and then by switching to an organic race

The build I'm testing this on is current as of 1 minute before I wrote this post.

I believe the sanity for this, triggered when the species is changed in the setup menu, is located at https://github.com/ParadiseSS13/Paradise/blob/master/code/modules/client/preferences.dm#L1148

Don't quite know how this was bypassed, maybe I'm misreading what is meant by the preferences panel or something.

Spacemanspark commented 8 years ago

The amusing part is that Polaris actually has this as a feature, in a matter of speaking.

lolzyking commented 8 years ago

from character setup in at log in, interestingly surgery works, it just works oddly with these body parts

it might be more of a sql or byond bug since I haven't updated my byond yet

KasparoVy commented 8 years ago

That's pretty wild, huh. I tried to emulate a case where the SQL might be causing the issue but it didn't seem to be the cause in my setup

I'll do what I can to try and test for if it's because one might be running 509 still, but I've little time because of finals and end of term projects

Sirryan2002 commented 2 years ago

duplicate of #4764