ParadiseSS13 / Paradise

Paradise Station's GitHub main repository.
https://www.paradisestation.org/forum
GNU Affero General Public License v3.0
404 stars 1.21k forks source link

Strange Defibrillator Behavior #4241

Closed Kerroman closed 6 years ago

Kerroman commented 8 years ago

Problem Description: Can use the defib paddles despite being on the other end of the map from the defibrillator unit.

What did you expect to happen: It is implied that the paddles are connected to the defib unit via some sort of cable because when you drop them they "snap back" to the unit. I would expect that at some point as you're moving away from the defib unit the tension on these cables would pull the paddles from your hand and snap them back to the defib unit no matter how hard you tried to hold onto them.

What happened instead: Leaving the defib unit in medbay (by the cryotubes) I walked, paddles in hand and freely able to switch between one-hand to two-hand wielding, all the way to the escape pods at arrivals and use them on a body that was there.

Why is this bad/What are the consequences: While it's not really THAT bad it's just silly and ridiculous, and it could possibly be exploited in some very mild ways.

Steps to reproduce the problem: Grab a defib from medbay. Right-click>Toggle Paddles. Drop defib unit and walk away. Use on corpse on the other end of the station.

Possibly related stuff (which gamemode was it? What were you doing at the time? Was anything else out of the ordinary happening?): This was tested on my own locally hosted server, although I updated it to the latest version of the Paradise git just yesterday so this should be reproducible on Paradise.

Here's some screenshots. Defib on ground, paddles in hand. The defib never moved from this spot while I was testing: https://i.gyazo.com/022213daa4702af1329d57f459a973b9.png

Chilling in one of the escape pods at arrivals, paddles still in hand: https://i.gyazo.com/cac66ec7b8b43d9dac4d40be66064aef.png

Oh look, a dead naked guy (there may or may not be an e-sword in my pocket.) Notice I'm in the process of defibbing him which the chat log confirmed. https://i.gyazo.com/a5aa2361dba215cef878bbe6c09e25ea.png

Oddly enough while holding the paddles if I hit "E" to equip them using hotkey mode the chatlog would show get spammed with 17 repeats of the following line. I hit "E" multiple times and for each time the chatlog showed 17 lines about wielding followed by the 1 about being unable to equip: https://gyazo.com/0d4f74f98a4568f6dc0a76bbea7c82ce

Bone-White commented 8 years ago

I can't reproduce this, likely because defibs can only be operated from your back, and you cannot drop directly from your back slot without going into your hand first (which docks the paddles)

That said, this bug is able to be reproduced by someone stripping the defib from you while you're wielding the paddles.