ParadoxGameConverters / Vic2ToHoI4

Converts Victoria 2 saves into Hearts of Iron 4 mods.
MIT License
28 stars 21 forks source link

Ditch googletest & excess submodules #1608

Closed Zemurin closed 1 year ago

Zemurin commented 1 year ago

Personally I'd replace all those silly-long paths: #include "external/common_items/external/googletest/googlemock/include/gmock/gmock-matchers.h" with #include <gmock/gmock-matchers.h>" since the paths are already in includes for both windows and linux.

But that's a style issue and I leave the decision to you. I can search/replace if you want.

Idhrendur commented 1 year ago

Ugly as they are, I do have a preference for the explicit path names. Though maybe my opinion will shift over time.