ParadoxLabs-Inc / tokenbase

TokenBase is the foundational package for most ParadoxLabs extensions for Magento®. It provides a tokenized card storage mechanism that is similar to but more featureful than Magento_Vault, and abstract components of a payment gateway implementation for Magento built around those stored cards.
Apache License 2.0
3 stars 3 forks source link

#1 Reorganize `di.xml` elements according to the scope #2

Closed lbajsarowicz closed 1 year ago

lbajsarowicz commented 1 year ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[x] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Fixes: #1

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

di.xml configuration is moved around, so Developers who already customized/overridden the di.xml may encounter unexpected behavior

Other information

🙏🏻 Kindly please add information to Release Notes "Optimized by SwiftOtter.com" when the change gets merged.

rhoerr commented 1 year ago

Replaced by cb4137c8a2133ada5e711ae164f2928a9f7a07b7. Moved only the frontend- and adminhtml-specific types to their respective scopes.

Thanks