ParadoxSpiral / libmpv-rs

A libmpv abstraction written in rust that's easy to use and provides the ability to read next to all video and audio codecs.

GNU Lesser General Public License v2.1

99 stars 35 forks source link

Add render API wrapper #20

Closed sztomi closed 3 years ago

sztomi commented 3 years ago

I started working on a wrapper for the rendering API. I've never done anything like this, so it's probably full of questionable things... let me know if this is at least in a direction you would be open to merging, and if you have specific concerns.

9 #11

anlumo commented 3 years ago

I did some cleanup in my fork here. I have yet to test it, though, but it does compile without any warnings or clippy complaints.

sztomi commented 3 years ago

@anlumo thanks a lot for looking into this. I know I was probably doing some sketchy things, I'm pretty new to Rust. I'm also not sure about that list of pointers that drop frees. But if I remember correctly I couldn't find any guidance in the mpv docs about the expected lifetimes of these variables so I figured that it's best to keep them around.

anlumo commented 3 years ago

See #22. I'm able to watch video via OpenGL!

sztomi commented 3 years ago

@anlumo awesome! I'll close this one then. Thanks a bunch for keeping at it.