Make bindgen optional in mpv-sys

ParadoxSpiral / libmpv-rs

A libmpv abstraction written in rust that's easy to use and provides the ability to read next to all video and audio codecs.

GNU Lesser General Public License v2.1

100 stars 36 forks source link

Make bindgen optional in mpv-sys #3

Closed Cobrand closed 6 years ago

Cobrand commented 6 years ago

This is a WIP. Here are a few issues that I thought this PR would fix:

Using bindgen should be optional, because not everybody can afford the llvm dependency, especially on windows machines.
The impls that are in src/lib.rs definitely shouldn't be there (and I can't see how it was possible before, it's not possible anymore now), and should be moved to mpv if they are really needed.

Your main mpv lib has to be updated, but I'd like you to compile everything and tell me which route to take before messing with your mpv crate itself.

This change is

ParadoxSpiral commented 6 years ago

Sorry about the delay, I didn't get an e-mail about this (which also hasn't happened numerous times for various other issues/prs…), I'll take a look soon!

ParadoxSpiral commented 6 years ago

Thanks for the PR!

With the removed impls this is one of those cases where it'd be nice to have a local impl that isn't bound by the coherence rules. I guess it's fine to move the impls to a utils module.

ParadoxSpiral commented 6 years ago

So I think I'll incorporate these changes in a big PR that updates to the newest libmpv version. Apparently opengl_callback was deprecated, so this will end up as a bigger change.