search

ParagonIaC / terraform-provider-activedirectory

Terraform Active Directory provider
Apache License 2.0
11 stars 6 forks source link

Group reasource #25

Open MrJacek opened 4 years ago

MrJacek commented 4 years ago

Hi, I would like to thank you for this provider. The code is really clean and it works nicely on it. What you have already written in it is a very good basis for it to be easily and quickly developed.

I guess you plan to implement the group resource. I have already implemented this functionality for my needs. Unfortunately, in the near future I will not have time to add acceptance tests. Nevertheless, I hope that what I have written so far will be helpful.

Thanks again for sharing this project.

adlerrobert commented 4 years ago

This looks very good. Thanks! I will be away for two weeks. After this I will review the code.

ingwarsw commented 4 years ago

This looks very good. Thanks! I will be away for two weeks. After this I will review the code.

@adlerrobert Still planing to merge it? I need it in my project.. and I will be adding user resource..

elongstreet88 commented 4 years ago

@MrJacek, i'm trying to build your pull request, but terraform is throwing "The provider provider.activedirectory does not support resource type - "activedirectory_group". I verified the resource go files exist and have the correct branch, but no luck. Is there a special build command needed? just using: go build

MrJacek commented 3 years ago

Hi, sorry for not responding for so long time I was busy. When I am return to this code and discovered that we was using deprecated sdk for terraform plugin.. so I refactor all code to match new requirement. Please close this PR and if you have time please check new PR: #28 I added group resources also there.