search

ParallaxTeam / HyparElementConverters

This repo hosts the Hypar Converters that Parallax Team is working on.
MIT License
2 stars 3 forks source link

fix guid issues #16

Open andrewheumann opened 3 years ago

andrewheumann commented 3 years ago

I noticed the curtain wall converter wasn't consistently exporting — sometimes I would get nothing, other times I would get only one curtain wall.

This was due to ID conflicts — curtain wall elements were all being stored under Guid.Empty. This creates a new guid for relevant elements in the converter. I tested and after this change was able to see all expected elements.

(This may ultimately be the fault of Elements — we may have changed our handling of guids to not automatically generate one if we encounter Empty at some point. but in any case, this is needed now.)

This change is Reviewable

johnpierson commented 3 years ago

Much appreciated! I ran into similar default values being different in elements for materials as well.