search

ParallelSSH / ssh2-python

Python bindings for libssh2 C library.
https://parallel-ssh.org
GNU Lesser General Public License v2.1
228 stars 72 forks source link

Enums and prep work for method_pref #134

Closed Red-M closed 3 years ago

Red-M commented 3 years ago

Add enums to allow type checks and bitmasks to easily be identified and what options are supported. This helps for #128 as it also includes any header changes required and as a nice bonus allows for enums to be added for groups of bitmasks and other symbols.

pkittenis commented 3 years ago

Not sure what this PR is for since there is no use of the modified code, anywhere, that can be seen.

The changes also create duplicates of existing classes, like SFTP and duplicate definitions of existing attributes from ssh2.sftp among others.

If there was something being implemented, with examples and test code, could then review this.

At the moment it is not clear what the use case is for these changes and cannot review or merge.

pkittenis commented 3 years ago

Review above.