Add Linux AArch64 wheel build support

odidev commented 3 years ago

Closes https://github.com/ParallelSSH/ssh2-python/issues/153

pkittenis commented 3 years ago

Thanks for the PR.

I am willing to merge this as ARM64 is the next most used architecture after the existing wheels, and these are only built on releases which are pretty infrequent.

There are a couple things needed:

Make an ARM64 Dockerfile and update script to use it. See existing dockerfile. The sed method will not work as it will make unstaged changes to the repo, see comments.
Update CI configuration to build and test the ARM64 release only on this PR to confirm the build works. Will need to comment out the filters: section otherwise manylinux2014-aarc64 does not get triggered. Will also need to give CircleCI permissions to the github account making this PR for builds to get triggered on it. Can then add the filters back when build is working.

odidev commented 3 years ago

Build is failing with WARNING: Built wheel for ssh2-python is invalid: Metadata 1.2 mandates PEP 440 version, but '0.26.0-2-gb283190' is not.

This seems a recent change, previously could install these, but in any case in order to confirm the build works can you please replace the ssh2/_version.py file with the following contents:
import json

version_json = '''
"0.99.0"'''  # END VERSION_JSON

def get_versions():
    return json.loads(version_json)
This file will also need reverting, along with the CI filters, once the build is confirmed to work correctly. It looks good other than the version thing.

The test failures look not relevant, probably from a CI environment change. Will take a look separately.

Editing ssh2/_version.py(commit #2fb6067) isn't working. Please take a look at these logs: https://app.circleci.com/pipelines/github/odidev/ssh2-python/33/workflows/2094e331-5df8-4fa4-b7b6-7e3c4fcf11ef/jobs/120

To test this on tag creation, I released a tag and wheel build look to be working fine. Please take a look at these logs: https://app.circleci.com/pipelines/github/odidev/ssh2-python/36/workflows/3bdd6111-8dd9-4881-9750-477d69e29430/jobs/129

pkittenis commented 3 years ago

Thanks for making these changes. Looks good to me. Will take a look at the build failures separately to be able to merge this.

odidev commented 3 years ago

@pkittenis, can you please let me know if you get a change to look into it?

pkittenis commented 3 years ago

Not yet I'm afraid. When I get some time.

odidev commented 3 years ago

Closed and reopened to trigger the build.

ParallelSSH / ssh2-python

Add Linux AArch64 wheel build support #154