search

ParallelSSH / ssh2-python

Python bindings for libssh2 C library.
https://parallel-ssh.org
GNU Lesser General Public License v2.1
228 stars 70 forks source link

Macos ARM architecture wheel #159

Closed gersmann closed 2 years ago

gersmann commented 2 years ago

I noticed, that there doesn't seem to be a binary wheel for Macos M1 (ARM arch). I did run ci/osx-wheel.sh locally and build a wheel distribution. Could I somehow make that available to you, so that it can be included in the package?

pkittenis commented 2 years ago

Thanks for the interest.

Unless an ARM OSX target appears on CircleCI there isn't going to be an arm wheel published. While it's nice you can make one, it needs to be automated as part of the release to be of use, which means support on CircleCI.

Unlikely unless that architecture gets a lot more products.

gersmann commented 2 years ago

Ah, yes. But would it be possible to create a universal binary, like that:

CMAKE_OSX_ARCHITECTURES=arm64;x86_64

pkittenis commented 2 years ago

That's for cross-compiling and would only work for cmake. The python wheel build does not use cmake, that's only for libssh2 itself.

gersmann commented 2 years ago

Ah ok, thx.

gersmann commented 2 years ago

@pkittenis thanks for the excellent lib, by the way, it's been a very nice upgrade from the previous library we've been using.

pkittenis commented 2 years ago

Have a look at the high level clients based on this library in parallel-ssh if you haven't already. This library is intentionally not high level.

gersmann commented 2 years ago

didn't check out parallel-ssh, but ssh2-python does work well for us, especially some edge cases like 2FA (cert + password auth).

tanzim commented 1 year ago

Now that CircleCI supports Apple Silicone, time for a revisit? https://support.circleci.com/hc/en-us/articles/360056461452-Apple-M1-Apple-Silion-Support-on-CircleCI