ParallelSSH / ssh2-python

Python bindings for libssh2 C library.
https://parallel-ssh.org
GNU Lesser General Public License v2.1
228 stars 70 forks source link

Update libssh2 version to 1.11.0 #183

Open ionutbaltariu opened 1 year ago

ionutbaltariu commented 1 year ago

libssh2 has to be updated to the latest version in order to fix a bug mentioned in https://github.com/ParallelSSH/ssh2-python/issues/178

The fix on the libssh2 side was mentioned here: https://github.com/libssh2/libssh2/issues/764

BONUS: Add steps in documentation to do this update locally, as in:

pkittenis commented 1 year ago

Pending release of new libssh2 version.

1.10.0 is still the latest version, and that is what is in the repository. This project tracks official releases, not master branch of libssh2.

ionutbaltariu commented 1 year ago

I understand. However, could you provide some steps to manually update the libssh2 version for the project? I imagine that I could clone the master branch of libssh2 and just do some setup steps to reinstall ssh2-python.

pkittenis commented 1 year ago

Sure, building with system/self provided libssh2 is documented here.

ionutbaltariu commented 1 year ago

I have tried to use the documented instructions in order to install ssh2-python with a self-built libssh2 from the latest version on their github repository.

However, it just seems it is not a really trivial task. Does installing under Windows also require installing OpenSSL? While trying to install I get the following error:

LINK : fatal error LNK1181: cannot open input file 'libcrypto64MD.lib'

ionutbaltariu commented 1 year ago

This is the way I've built libssh2 on Windows:

mkdir dll
cd dll
cmake -DCRYPTO_BACKEND=WinCNG -DBUILD_SHARED_LIBS=ON ..
cmake --build . --target install

Then I've used python .\setup.py build_ext -I C:\libssh2\dll\src\ -L C:\libssh2\dll\src\Debug (Debug is where I found the dll/lib files). I'm really feeling like doing things without actually knowing what they trully mean. Could you help me in this issue?

tmzhuang commented 1 year ago

@pkittenis as an update, libssh2 release is slated for May 30 2023 according to this thread.

ionutbaltariu commented 1 year ago

@pkittenis libssh2 1.11 was released today. Could you also update ssh2-python?

sand-prs commented 4 months ago

Any updates as to when a fix for ssh2-python will be ready?