Parallels / artifactory

A Python client for Artifactory
MIT License
82 stars 54 forks source link

Fail in get_stat_json on virtual repository #66

Open Basilious opened 5 years ago

Basilious commented 5 years ago

Hi,

I am trying to upload via the deploy_file method, and i had issue uploading through a virtual repository with error "404, Not found", what does not make sense because i am trying to upload a new file that he shouldn't be exists any way.

So after debugging the error trace back i found that in the API when i try to reach a file is not exists, i had different behavior if it is virtual repo or not;

in regular repository i get this: { "errors" : [ { "status" : 404, "message" : "Unable to find item" } ] }

however in the virtual repository i get a different error message: { "errors" : [ { "status" : 404, "message" : "Not Found" } ] }

And the library method artifactory.py in get_stat_json (Line 457), if code == 404 and "Unable to find item" in text:

Which make this condition not working in virtual repository.

Thank you very much.

cowlinator commented 5 years ago

This repo is currently outdated There is an active fork of this library available at https://github.com/devopshq/artifactory